Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux_xanmod, linux_xanmod_latest: 2024-12-20 #367161

Merged
merged 2 commits into from
Dec 23, 2024
Merged

linux_xanmod, linux_xanmod_latest: 2024-12-20 #367161

merged 2 commits into from
Dec 23, 2024

Conversation

Shawn8901
Copy link
Contributor

@Shawn8901 Shawn8901 commented Dec 21, 2024 •
edited
Loading

still building lts
lts runs fine on my setup

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: kernel The Linux kernel label Dec 21, 2024
@Shawn8901 Shawn8901 added backport release-24.11 Backport PR automatically 6.topic: kernel The Linux kernel and removed 6.topic: kernel The Linux kernel labels Dec 21, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501-1000 labels Dec 21, 2024
@Shawn8901 Shawn8901 marked this pull request as ready for review December 21, 2024 18:35
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 501+ labels Dec 22, 2024
eljamm
eljamm approved these changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with main

@eljamm eljamm added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 22, 2024
@Shawn8901
Copy link
Contributor Author

@eljamm as you have reviewed some prs in the past i assume that you are actively using xanmod. If you like to get pinged for testing of updates you could add yourself as maintainer. Just if you like to. 🙂

@eljamm
Copy link
Contributor

eljamm commented Dec 22, 2024 •
edited
Loading

Thanks @Shawn8901. I've been using Xanmod for many months, now, and I really like it. I'd also like to be a maintainer, so I'll open a PR for this some time later.

@moni-dz moni-dz added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 22, 2024
@Atemu Atemu merged commit 8ae7ef7 into NixOS:master Dec 23, 2024
82 of 83 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 23, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 23, 2024
Merged
1 task
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 23, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-367161-to-release-24.05 origin/release-24.05
cd .worktree/backport-367161-to-release-24.05
git switch --create backport-367161-to-release-24.05
git cherry-pick -x eac567d371ca82ecf849c23766bb89b9cc9a64ec e94db5feff365f6f24302a72c053febe5e5e430c

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 23, 2024

Git push to origin failed for release-24.11 with exitcode 1

@Atemu
Copy link
Member

Atemu commented Dec 23, 2024

24.05 is still supported until EOY.

@Shawn8901 Shawn8901 deleted the update-xanmod branch December 23, 2024 09:31
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 24, 2024

Successfully created backport PR for release-24.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 24, 2024
Merged
1 task
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 24, 2024

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-367161-to-release-24.11 origin/release-24.11
cd .worktree/backport-367161-to-release-24.11
git switch --create backport-367161-to-release-24.11
git cherry-pick -x eac567d371ca82ecf849c23766bb89b9cc9a64ec e94db5feff365f6f24302a72c053febe5e5e430c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moni-dz moni-dz moni-dz approved these changes

@eljamm eljamm eljamm approved these changes

@Atemu Atemu Awaiting requested review from Atemu

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@zzzsyyy zzzsyyy Awaiting requested review from zzzsyyy

Assignees
No one assigned
Labels
6.topic: kernel The Linux kernel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shawn8901 @eljamm @Atemu @moni-dz